Skip to content

fix: imagick version to 3.8.1#7

Merged
ChiragAgg5k merged 3 commits intomainfrom
fix-imagick-version
Dec 5, 2025
Merged

fix: imagick version to 3.8.1#7
ChiragAgg5k merged 3 commits intomainfrom
fix-imagick-version

Conversation

@ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented Dec 5, 2025 •
edited by coderabbitai bot
Loading

Screenshot 2025-12-05 at 4 15 09 PM

https://github.com/Imagick/imagick/releases/tag/3.8.0

Summary by CodeRabbit

  • Chores

    • Updated runtime component versions: PHP SWOOLE upgraded to v6.1.3 and Imagick to 3.8.1 in environment configuration.

  • Tests

    • Extended CI test matrix to include PHP 8.4, broadening automated test coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025 •
edited
Loading

Walkthrough

Bumped extension versions in php-8.4/Dockerfile: PHP_SWOOLE_VERSION changed from v5.1.7 to v6.1.3 and PHP_IMAGICK_VERSION changed from 3.7.0 to 3.8.1. Updated GitHub Actions workflow .github/workflows/test.yml to include PHP 8.4 in the test matrix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are small and localized across two files.
  • One file contains two environment version bumps; the other expands the CI PHP version matrix.

Areas to check during review:

  • Swoole v6.x potential breaking changes vs. current code/extension usage.
  • Imagick 3.8.1 compatibility with PHP 8.4 and project image-processing code.
  • Dockerfile build succeeds with the new versions (compile/link errors).
  • CI run for the added PHP 8.4 matrix entry.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title focuses on updating imagick to 3.8.1, but the changeset also updates PHP_SWOOLE_VERSION and expands the test matrix to PHP 8.4. The title captures only one aspect of the changes. Consider a more comprehensive title that reflects all significant changes, such as 'chore: update PHP 8.4 support with dependencies' or ensure the PR scope is narrower if only imagick updates are intended.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-imagick-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

loks0n
loks0n previously approved these changes Dec 5, 2025
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Dec 5, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79a3efd and bf44d8c.

📒 Files selected for processing (1)
  • php-8.4/Dockerfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build (8.2)
  • GitHub Check: build (8.1)
  • GitHub Check: build (8.3)
  • GitHub Check: build (8.4)
  • GitHub Check: build (8.0)
🔇 Additional comments (1)
php-8.4/Dockerfile (1)

1-196: Build structure is sound.

The multi-stage Docker build pattern is well-implemented, with proper use of environment variables for version management and consistent extension compilation and installation across stages.

@ChiragAgg5k ChiragAgg5k merged commit f7a6aa3 into main Dec 5, 2025
6 checks passed
@ChiragAgg5k ChiragAgg5k deleted the fix-imagick-version branch December 5, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@loks0n loks0n loks0n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ChiragAgg5k @loks0n